Association with finder_sql raises TypeError

192

true

2007-09-29T05:27:11+02:00

8322

120 paginate-association-with-finder_sql-raises-typeerror 32

17958

invalid will_paginate Association with finder_sql raises TypeError

2010-01-13T17:26:49+01:00

8322

wildchild

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/120

In case when finder_sql || counter_sql is used, attempt to paginate association raises TypeError: can't convert nil into Array Attached failing test case.

<div> In case when finder_sql || counter_sql is used, attempt to paginate association raises TypeError: can't convert nil into Array Attached failing test case. </div>

192

true

2009-06-25T03:42:02+02:00

42446

272 per_page-and-composite_primary_keys 124

17958

invalid page per_page and composite_primary_keys

2009-06-27T16:02:07+02:00

192

Mislav

mephux

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/272

It seems per_page breaks when using the composite_primary_keys plugin. Seems to put a limit for both ids and duplicating items. vent Load (0.6ms) SELECT * FROM `event` ORDER BY timestamp DESC LIMIT 50, 5

<div>It seems per_page breaks when using the composite_primary_keys plugin. Seems to put a limit for both ids and duplicating items. vent Load (0.6ms) SELECT * FROM <code>event</code> ORDER BY timestamp DESC LIMIT 50, 5</div>

192

false

2009-06-25T04:04:54+02:00

36253

273 passing-nil-to-paginate_by_-fails 125

17958

new paginate_by will_paginate Passing nil to paginate_by_* fails

2009-06-25T04:04:57+02:00

36253

Nick Hoffman

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/273

Hi guys. I'm using: * will_paginate 2.3.8 * Rails 2.3.2 * Ruby 1.8.7 I noticed that searching for a nil value using #paginate_by_* fails with an error. First, it works with an integer: @@@ ?> Keyword.paginate_by_number_of_google_results 12_000, :page => 1 => [#<Keyword id: 110472, keyword: "foo bar", estimated_cpc: #<BigDecimal:3a91138,'0.5342E2',8(8)>, created_at: "2009-06-25 01:30:11", updated_at: "2009-06-25 01:33:54", keyword_list_id: 35, hot: nil, number_of_google_results: 12000>] @@@ However, it fails with nil: @@@ Keyword.paginate_by_number_of_google_results nil, :page => 1 ActiveRecord::PreparedStatementInvalid: wrong number of bind variables (0 for 1) in: `keywords`.`number_of_google_results` is ? from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2399:in `raise_if_bind_arity_mismatch' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2351:in `replace_bind_variables' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2342:in `sanitize_sql_array' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2235:in `sanitize_sql_orig' from /Users/nick/src/adsense_keywords/vendor/gems/ar-extensions-0.9.1/lib/ar-extensions/finders.rb:35:in `sanitize_sql' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:1499:in `merge_conditions' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:1497:in `each' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:1497:in `merge_conditions' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2122:in `with_scope' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2116:in `each' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2116:in `with_scope' from (irb):119:in `inject' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2112:in `each' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2112:in `inject' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2112:in `with_scope' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_collection.rb:176:in `send' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_collection.rb:176:in `count' from /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:223:in `wp_count' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2148:in `with_scope' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_proxy.rb:206:in `send' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_proxy.rb:206:in `with_scope' from /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:233:in `wp_count' from /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:85:in `paginate' from /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/collection.rb:87:in `create' from /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:76:in `paginate' from /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:184:in `method_missing' from (irb):119 @@@ The line above should be equivalent to this: @@@ Keyword.paginate :conditions => {:number_of_google_results => nil}, :page => 1 @@@ Cheers, Nick --- Here's the output from running the will_paginate tests: @@@ $ rake test (in /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8) /opt/local/bin/ruby -I"/Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib" -I"/Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/test" "/opt/local/lib/ruby/gems/1.8/gems/rake-0.8.4/lib/rake/rake_test_loader.rb" "test/collection_test.rb" "test/finder_test.rb" "test/view_test.rb" using Rails gems Loaded suite /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.4/lib/rake/rake_test_loader Started .......................................E...................................................... Finished in 0.897438 seconds. 1) Error: test_paginate_in_named_scope_on_hmt_association(FinderTest): ActiveRecord::StatementInvalid: SQLite3::SQLException: near "*": syntax error: SELECT count("replies".*) AS count_replies_all FROM "replies" INNER JOIN "topics" ON "replies".topic_id = "topics".id WHERE (((replies.created_at > '2009-06-24 21:49:20') AND (("topics".project_id = 1))) AND (("topics".project_id = 1))) /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/abstract_adapter.rb:212:in `log' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/sqlite_adapter.rb:157:in `execute_without_counting' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/sqlite_adapter.rb:402:in `catch_schema_changes' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/sqlite_adapter.rb:157:in `execute_without_counting' /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/test/lib/activerecord_test_connector.rb:69:in `execute' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/sqlite_adapter.rb:305:in `select' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/abstract/database_statements.rb:7:in `select_all_without_query_cache' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/abstract/query_cache.rb:62:in `select_all' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/abstract/database_statements.rb:13:in `select_one' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/abstract/database_statements.rb:19:in `select_value' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/calculations.rb:243:in `execute_simple_calculation' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/calculations.rb:134:in `calculate' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/calculations.rb:130:in `catch' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/calculations.rb:130:in `calculate' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/calculations.rb:48:in `count' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_collection.rb:176:in `count' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2148:in `with_scope' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_collection.rb:176:in `send' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_collection.rb:176:in `count' /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:223:in `wp_count' /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:235:in `call' /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:235:in `wp_count' /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:85:in `paginate' /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/collection.rb:87:in `create' /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:76:in `paginate' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_proxy.rb:145:in `send' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_proxy.rb:145:in `send' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/named_scope.rb:183:in `method_missing' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2148:in `with_scope' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_proxy.rb:206:in `send' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_proxy.rb:206:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/named_scope.rb:182:in `method_missing' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2148:in `with_scope' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_proxy.rb:206:in `send' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_proxy.rb:206:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/named_scope.rb:179:in `method_missing' ./test/finder_test.rb:248:in `test_paginate_in_named_scope_on_hmt_association' /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/test/lib/activerecord_test_case.rb:33:in `assert_queries' ./test/finder_test.rb:247:in `test_paginate_in_named_scope_on_hmt_association' /opt/local/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/testing/setup_and_teardown.rb:62:in `__send__' /opt/local/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/testing/setup_and_teardown.rb:62:in `run' /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/test/lib/activerecord_test_case.rb:22:in `run' 94 tests, 349 assertions, 0 failures, 1 errors rake aborted! Command failed with status (1): [/opt/local/bin/ruby -I"/Users/nick/src/ads...] (See full trace by running task with --trace) @@@

<div>Hi guys. I'm using: * will_paginate 2.3.8 * Rails 2.3.2 * Ruby 1.8.7 I noticed that searching for a nil value using #paginate_by_* fails with an error. First, it works with an integer: <pre><code> ?> Keyword.paginate_by_number_of_google_results 12_000, :page => 1 => [#<Keyword id: 110472, keyword: "foo bar", estimated_cpc: #<BigDecimal:3a91138,'0.5342E2',8(8)>, created_at: "2009-06-25 01:30:11", updated_at: "2009-06-25 01:33:54", keyword_list_id: 35, hot: nil, number_of_google_results: 12000>] </code></pre> However, it fails with nil: <pre><code> Keyword.paginate_by_number_of_google_results nil, :page => 1 ActiveRecord::PreparedStatementInvalid: wrong number of bind variables (0 for 1) in: `keywords`.`number_of_google_results` is ? from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2399:in `raise_if_bind_arity_mismatch' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2351:in `replace_bind_variables' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2342:in `sanitize_sql_array' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2235:in `sanitize_sql_orig' from /Users/nick/src/adsense_keywords/vendor/gems/ar-extensions-0.9.1/lib/ar-extensions/finders.rb:35:in `sanitize_sql' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:1499:in `merge_conditions' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:1497:in `each' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:1497:in `merge_conditions' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2122:in `with_scope' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2116:in `each' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2116:in `with_scope' from (irb):119:in `inject' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2112:in `each' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2112:in `inject' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2112:in `with_scope' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_collection.rb:176:in `send' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_collection.rb:176:in `count' from /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:223:in `wp_count' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2148:in `with_scope' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_proxy.rb:206:in `send' from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_proxy.rb:206:in `with_scope' from /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:233:in `wp_count' from /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:85:in `paginate' from /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/collection.rb:87:in `create' from /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:76:in `paginate' from /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:184:in `method_missing' from (irb):119 </code></pre> The line above should be equivalent to this: <pre><code> Keyword.paginate :conditions => {:number_of_google_results => nil}, :page => 1 </code></pre> Cheers, Nick <hr> Here's the output from running the will_paginate tests: <pre><code> $ rake test (in /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8) /opt/local/bin/ruby -I"/Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib" -I"/Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/test" "/opt/local/lib/ruby/gems/1.8/gems/rake-0.8.4/lib/rake/rake_test_loader.rb" "test/collection_test.rb" "test/finder_test.rb" "test/view_test.rb" using Rails gems Loaded suite /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.4/lib/rake/rake_test_loader Started .......................................E...................................................... Finished in 0.897438 seconds. 1) Error: test_paginate_in_named_scope_on_hmt_association(FinderTest): ActiveRecord::StatementInvalid: SQLite3::SQLException: near "*": syntax error: SELECT count("replies".*) AS count_replies_all FROM "replies" INNER JOIN "topics" ON "replies".topic_id = "topics".id WHERE (((replies.created_at > '2009-06-24 21:49:20') AND (("topics".project_id = 1))) AND (("topics".project_id = 1))) /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/abstract_adapter.rb:212:in `log' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/sqlite_adapter.rb:157:in `execute_without_counting' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/sqlite_adapter.rb:402:in `catch_schema_changes' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/sqlite_adapter.rb:157:in `execute_without_counting' /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/test/lib/activerecord_test_connector.rb:69:in `execute' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/sqlite_adapter.rb:305:in `select' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/abstract/database_statements.rb:7:in `select_all_without_query_cache' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/abstract/query_cache.rb:62:in `select_all' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/abstract/database_statements.rb:13:in `select_one' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/abstract/database_statements.rb:19:in `select_value' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/calculations.rb:243:in `execute_simple_calculation' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/calculations.rb:134:in `calculate' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/calculations.rb:130:in `catch' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/calculations.rb:130:in `calculate' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/calculations.rb:48:in `count' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_collection.rb:176:in `count' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2148:in `with_scope' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_collection.rb:176:in `send' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_collection.rb:176:in `count' /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:223:in `wp_count' /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:235:in `call' /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:235:in `wp_count' /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:85:in `paginate' /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/collection.rb:87:in `create' /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:76:in `paginate' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_proxy.rb:145:in `send' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_proxy.rb:145:in `send' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/named_scope.rb:183:in `method_missing' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2148:in `with_scope' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_proxy.rb:206:in `send' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_proxy.rb:206:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/named_scope.rb:182:in `method_missing' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2148:in `with_scope' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_proxy.rb:206:in `send' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_proxy.rb:206:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/named_scope.rb:179:in `method_missing' ./test/finder_test.rb:248:in `test_paginate_in_named_scope_on_hmt_association' /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/test/lib/activerecord_test_case.rb:33:in `assert_queries' ./test/finder_test.rb:247:in `test_paginate_in_named_scope_on_hmt_association' /opt/local/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/testing/setup_and_teardown.rb:62:in `__send__' /opt/local/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/testing/setup_and_teardown.rb:62:in `run' /Users/nick/src/adsense_keywords/vendor/gems/mislav-will_paginate-2.3.8/test/lib/activerecord_test_case.rb:22:in `run' 94 tests, 349 assertions, 0 failures, 1 errors rake aborted! Command failed with status (1): [/opt/local/bin/ruby -I"/Users/nick/src/ads...] (See full trace by running task with --trace) </code></pre></div>

192

false

2008-06-18T22:27:51+02:00

20082

231 option-to-omit-page-1-parameter-on-page-one 94

17958

open patch view will_paginate Option to omit page=1 parameter on page one

2009-06-10T20:05:37+02:00

52130

ippa

Brad Folkens

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/231

View helper should allow the omission of the page=1 URL parameter with the :omit_page_one option.

<div> View helper should allow the omission of the page=1 URL parameter with the :omit_page_one option. </div>

192

false

2009-05-29T12:26:27+02:00

35069

271 add-support-for-i18n 123

17958

new helpers i18n localize view Add support for i18n

2009-05-29T12:26:28+02:00

35069

Paul Springett

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/271

The ability to localize the view helpers without having to overwrite the helper methods (such as page_entries_info) would be awesome

<div>The ability to localize the view helpers without having to overwrite the helper methods (such as page_entries_info) would be awesome</div>

192

true

2009-05-27T22:35:27+02:00

58111

270 include-brings-back-more-records-then-i-specify-per-page 122

17958

invalid include :include brings back more records then I specify per page

2009-05-27T23:13:48+02:00

58111

Brian

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/270

If I call paginate on a Model.all with an :include specified, the query that brings back the included records is pulling back all the records instead of only the included records for the current page. Below is an example: MspLocation.all(:include => [{:msp_profile => [:msp_services]}], :joins => [:msp_profile], :conditions => ["country = ?", country], :order => "company_name").paginate(:page => 1) ** I have the page size set to 30 the previous command generates the following log output MspLocation Load (3.2ms) SELECT "msp_locations".* FROM "msp_locations" INNER JOIN "msp_profiles" ON "msp_profiles".id = "msp_locations".msp_profile_id WHERE (country = E'United States') ORDER BY company_name MspProfile Load (1.2ms) SELECT * FROM "msp_profiles" WHERE ("msp_profiles"."id" IN (22,66,55,44,33,11,23,56,45,34,7,67,24,57,46,35,8,68,25,58,47,36,70,69,60,59,48,37,26,71,61,50,49,38,16,27,62,51,40,39,28,17,63,52,41,18,30,29,64,20,53,19,42,31,21,65,54,43,32,5)) As you can see, the second query is bringing back more then 30 records. I would expect it to only bring back the records the view needs to display for the current page.

<div>If I call paginate on a Model.all with an :include specified, the query that brings back the included records is pulling back all the records instead of only the included records for the current page. Below is an example: MspLocation.all(:include => [{:msp_profile => [:msp_services]}], :joins => [:msp_profile], :conditions => ["country = ?", country], :order => "company_name").paginate(:page => 1) ** I have the page size set to 30 the previous command generates the following log output MspLocation Load (3.2ms) SELECT "msp_locations".* FROM "msp_locations" INNER JOIN "msp_profiles" ON "msp_profiles".id = "msp_locations".msp_profile_id WHERE (country = E'United States') ORDER BY company_name MspProfile Load (1.2ms) SELECT * FROM "msp_profiles" WHERE ("msp_profiles"."id" IN (22,66,55,44,33,11,23,56,45,34,7,67,24,57,46,35,8,68,25,58,47,36,70,69,60,59,48,37,26,71,61,50,49,38,16,27,62,51,40,39,28,17,63,52,41,18,30,29,64,20,53,19,42,31,21,65,54,43,32,5)) As you can see, the second query is bringing back more then 30 records. I would expect it to only bring back the records the view needs to display for the current page.</div>

192

false

2008-07-08T21:05:05+02:00

25668

237 paginate_by_sql-fails-when-using-oracle-and-the-jdbc-driver 98

17958

open jdbc oracle will_paginate paginate_by_sql fails when using Oracle and the jdbc driver.

2009-05-21T23:36:17+02:00

192

Mislav

squirrelbone

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/237

Why not remove the following block of code altogether? @@@ ruby unless ['oracle', 'oci'].include?(self.connection.adapter_name.downcase) count_query << ' AS count_table' end @@@ When using JDBC connection.adapter_name shows up as jdbc regardless of the database. So this will fail for Oracle when using JDBC and when the inner select statement returns no rows. @@@ ruby count_query = "SELECT COUNT(*) FROM (#{count_query})" @@@

<div> Why not remove the following block of code altogether? <pre><code class="ruby">unless ['oracle', 'oci'].include?(self.connection.adapter_name.downcase) count_query << ' AS count_table' end </code></pre> When using JDBC connection.adapter_name shows up as jdbc regardless of the database. So this will fail for Oracle when using JDBC and when the inner select statement returns no rows. <pre><code class="ruby">count_query = "SELECT COUNT(*) FROM (#{count_query})" </code></pre></div>

192

true

2009-04-02T09:03:08+02:00

52778

267 install-will_paginate-plug-in 119

17958

invalid install will_paginate plug in

2009-05-20T11:44:09+02:00

192

Mislav

thiti

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/267

Hello , i stall will_paginate plug in by using >>mkdir vendor/plugins/will_paginate >> wget -nv http://github.com/mislav/will_paginate/tarball/master -O- | \tar xzv -C vendor/plugins/will_paginate --strip 1 i get this >>mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/.gitignore mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/.manifest mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/CHANGELOG.rdoc mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/LICENSE mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/README.rdoc mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/Rakefile mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/examples/ mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/examples/apple-circle.gif mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/examples/index.haml mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/examples/index.html mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/examples/pagination.css mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/examples/pagination.sass mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/init.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/ mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate/ mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate/array.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate/collection.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate/core_ext.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate/finder.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate/named_scope.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate/named_scope_patch.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate/version.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate/view_helpers.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/ mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/boot.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/collection_test.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/console mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/database.yml mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/finder_test.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/ mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/admin.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/developer.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/developers_projects.yml mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/project.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/projects.yml mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/replies.yml mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/reply.rb 2009-04-02 13:11:00 URL:http://download.github.com/mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556.tar.gz [36217/36217] -> "-" [1] mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/schema.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/topic.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/topics.yml mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/user.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/users.yml mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/helper.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/lib/ mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/lib/activerecord_test_case.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/lib/activerecord_test_connector.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/lib/load_fixtures.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/lib/view_test_process.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/tasks.rake mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/view_test.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/will_paginate.gemspec >>>>>>>>>>>>>>>>>>> after that i go to config/environments.rb add the require "will_paginate" at the bottom >>>and try the script >>s = Seq.paginate(:page => 1, :per_page => 5) NameError: uninitialized constant Seq::Post from /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:105:in `const_missing' from /home/apple/www/rcc_eri/app/models/seq.rb:7 from /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:380:in `load_without_new_constant_marking' from /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:380:in `load_file' from /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:521:in `new_constants_in' from /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:379:in `load_file' from /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:259:in `require_or_load' from /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:425:in `load_missing_constant' from /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:80:in `const_missing' from /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:92:in `const_missing' from (irb):2 >>>pls ,tell me what i missing? thank you

<div>Hello , i stall will_paginate plug in by using <blockquote> <blockquote> mkdir vendor/plugins/will_paginate wget -nv <a href="http://github.com/mislav/will_paginate/tarball/master">http://github.com/mislav/will_pa...</a> -O- | \tar xzv -C vendor/plugins/will_paginate --strip 1 i get this mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/.gitignore mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/.manifest mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/CHANGELOG.rdoc mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/LICENSE mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/README.rdoc mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/Rakefile mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/examples/ mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/examples/apple-circle.gif mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/examples/index.haml mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/examples/index.html mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/examples/pagination.css mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/examples/pagination.sass mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/init.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/ mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate/ mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate/array.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate/collection.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate/core_ext.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate/finder.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate/named_scope.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate/named_scope_patch.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate/version.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/lib/will_paginate/view_helpers.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/ mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/boot.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/collection_test.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/console mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/database.yml mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/finder_test.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/ mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/admin.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/developer.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/developers_projects.yml mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/project.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/projects.yml mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/replies.yml mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/reply.rb 2009-04-02 13:11:00 URL:http://download.github.com/mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556.tar.gz [36217/36217] -> "-" <a href="/projects/17958/changesets/1" title="Changeset #1">[1]</a> mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/schema.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/topic.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/topics.yml mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/user.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/fixtures/users.yml mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/helper.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/lib/ mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/lib/activerecord_test_case.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/lib/activerecord_test_connector.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/lib/load_fixtures.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/lib/view_test_process.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/tasks.rake mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/test/view_test.rb mislav-will_paginate-8888651be8d6656bdf2378731d91a8badbaa2556/will_paginate.gemspec >>>>>>>>>>>>>>>>>>> after that i go to config/environments.rb add the require "will_paginate" at the bottom <blockquote> and try the script s = Seq.paginate(:page => 1, :per_page => 5) NameError: uninitialized constant Seq::Post <pre> <code>from /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:105:in `const_missing' from /home/apple/www/rcc_eri/app/models/seq.rb:7 from /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:380:in `load_without_new_constant_marking' from /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:380:in `load_file' from /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:521:in `new_constants_in' from /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:379:in `load_file' from /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:259:in `require_or_load' from /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:425:in `load_missing_constant' from /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:80:in `const_missing' from /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:92:in `const_missing' from (irb):2 </code> </pre> pls ,tell me what i missing? thank you </blockquote> </blockquote> </blockquote></div>

192

true

2009-05-06T17:26:39+02:00

15518

269 problem-with-ruby-19x 121

17958

resolved associations bug count options patch ruby1.9 Problem with Ruby 1.9.x

2009-05-20T11:42:41+02:00

192

Mislav

Anton Ageev

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/269

In Ruby 1.9.x `WillPaginate::Finder::ClassMethods#wp_count` doesn't remove `:include` options in following code: # forget about includes if they are irrelevant (Rails 2.1) if count_options[:include] and klass.private_methods.include?('references_eager_loaded_tables?') and !klass.send(:references_eager_loaded_tables?, count_options) count_options.delete :include end `klass.private_methods` in ruby 1.8.x returns strings, in ruby 1.9.x returns symbols. Oneline patch: - klass.private_methods.include?('references_eager_loaded_tables?') + klass.private_methods.map { |n| n.to_sym }.include?(:references_eager_loaded_tables?)

<div>In Ruby 1.9.x <code>WillPaginate::Finder::ClassMethods#wp_count</code> doesn't remove <code>:include</code> options in following code: <pre> <code># forget about includes if they are irrelevant (Rails 2.1) if count_options[:include] and klass.private_methods.include?('references_eager_loaded_tables?') and !klass.send(:references_eager_loaded_tables?, count_options) count_options.delete :include end </code> </pre> <code>klass.private_methods</code> in ruby 1.8.x returns strings, in ruby 1.9.x returns symbols. Oneline patch: <pre> <code>- klass.private_methods.include?('references_eager_loaded_tables?') + klass.private_methods.map { |n| n.to_sym }.include?(:references_eager_loaded_tables?) </code> </pre></div>

192

false

2009-04-17T12:58:46+02:00

34931

268 exception-in-rails-232-when-using-group 120

17958

open group orderedhash rails-2.3.2 Exception in Rails 2.3.2 when using :group

2009-04-21T15:30:23+02:00

34931

Paco Benavent

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/268

Using will_paginate-2.3.8 with Rails 2.3.2 raises an exception when using :group Example: @@@ ruby User.paginate :all, :finder => 'count', :group => 'country', :page => 1 @@@ TypeError: can't convert ActiveSupport::OrderedHash into Array from /usr/lib/ruby/gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/collection.rb:135:in `replace' from /usr/lib/ruby/gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/collection.rb:135:in `replace' from /usr/lib/ruby/gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:82:in `paginate' from /usr/lib/ruby/gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/collection.rb:87:in `create' from /usr/lib/ruby/gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:76:in `paginate' from (irb):5 This is because in Rails 2.3.2, OrderedHash changed from being a subclass of Array to a subclass of Hash.

<div>Using will_paginate-2.3.8 with Rails 2.3.2 raises an exception when using :group Example: <pre><code class="ruby"> User.paginate :all, :finder => 'count', :group => 'country', :page => 1 </code></pre> <pre> <code>TypeError: can't convert ActiveSupport::OrderedHash into Array from /usr/lib/ruby/gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/collection.rb:135:in `replace' from /usr/lib/ruby/gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/collection.rb:135:in `replace' from /usr/lib/ruby/gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:82:in `paginate' from /usr/lib/ruby/gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/collection.rb:87:in `create' from /usr/lib/ruby/gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:76:in `paginate' from (irb):5 </code> </pre> This is because in Rails 2.3.2, OrderedHash changed from being a subclass of Array to a subclass of Hash.</div>

192

true

2009-03-31T16:07:40+02:00

35954

266 rendering-pagination-via-ajax-causes-the-links-to-point-to-ajax-method 118

17958

invalid ajax bug controller link method Rendering pagination via Ajax causes the links to point to ajax method

2009-04-01T12:02:40+02:00

192

Mislav

Michael Larkin

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/266

I use will_paginate in my application to page using non-ajaxy requests. However, the delete method in my grid is ajaxy, and replaces the entire grid (including pagination links) when an item is deleted. However, the pagination links no longer point to the index method, but instead to the delete, which is incorrect. For example: /promotions?page=2 is what it should be /promotions/:id/delete?page=2 is what it ends up being, which is obviously impossible because the object was just deleted so the route is not valid.

<div>I use will_paginate in my application to page using non-ajaxy requests. However, the delete method in my grid is ajaxy, and replaces the entire grid (including pagination links) when an item is deleted. However, the pagination links no longer point to the index method, but instead to the delete, which is incorrect. For example: /promotions?page=2 is what it should be /promotions/:id/delete?page=2 is what it ends up being, which is obviously impossible because the object was just deleted so the route is not valid.</div>

192

true

2009-01-16T20:51:32+01:00

16360

261 has_many-through-uniq-generates-invalid-sql 113

17958

invalid bug has_many named_scope through has_many through uniq generates invalid sql

2009-03-25T12:29:03+01:00

192

Mislav

Chad

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/261

@@@ ruby has_many :uniq_replies, :source => :replies, :through => :topics, :uniq => true @@@ pagination generates invalid sql. from test/console @@@ >> Project.first.uniq_replies.paginate(:page => 1, :per_page => 1) Project Load (0.3ms) SELECT * FROM "projects" LIMIT 1 Reply Load (0.8ms) SELECT DISTINCT "replies".* FROM "replies" INNER JOIN topics ON replies.topic_id = topics.id WHERE (("topics".project_id = 1)) LIMIT 1 OFFSET 0 SQL (0.0ms) SQLite3::SQLException: near "*": syntax error: SELECT count(DISTINCT "replies".*) AS count_distinct_replies_all FROM "replies" INNER JOIN topics ON replies.topic_id = topics.id WHERE (("topics".project_id = 1)) ActiveRecord::StatementInvalid: SQLite3::SQLException: near "*": syntax error: SELECT count(DISTINCT "replies".*) AS count_distinct_replies_all FROM "replies" INNER JOIN topics ON replies.topic_id = topics.id WHERE (("topics".project_id = 1)) @@@ I think the SQL should read: @@@ SQL SELECT DISTINCT "replies".id ... @@@

<div><pre><code class="ruby"> has_many :uniq_replies, :source => :replies, :through => :topics, :uniq => true </code></pre> pagination generates invalid sql. from test/console <pre><code> >> Project.first.uniq_replies.paginate(:page => 1, :per_page => 1) Project Load (0.3ms) SELECT * FROM "projects" LIMIT 1 Reply Load (0.8ms) SELECT DISTINCT "replies".* FROM "replies" INNER JOIN topics ON replies.topic_id = topics.id WHERE (("topics".project_id = 1)) LIMIT 1 OFFSET 0 SQL (0.0ms) SQLite3::SQLException: near "*": syntax error: SELECT count(DISTINCT "replies".*) AS count_distinct_replies_all FROM "replies" INNER JOIN topics ON replies.topic_id = topics.id WHERE (("topics".project_id = 1)) ActiveRecord::StatementInvalid: SQLite3::SQLException: near "*": syntax error: SELECT count(DISTINCT "replies".*) AS count_distinct_replies_all FROM "replies" INNER JOIN topics ON replies.topic_id = topics.id WHERE (("topics".project_id = 1)) </code></pre> I think the SQL should read: @@@ SQL SELECT DISTINCT "replies".id ... <pre><code> </code></pre></div>

192

true

2009-03-21T22:01:03+01:00

46326

265 incorrect-counts-in-rails-23 117

17958

invalid Incorrect counts in rails 2.3

2009-03-21T23:36:24+01:00

192

Mislav

Diegorv

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/265

I have this code @@@ def self.completa(estado_id, cidade_id, bairro_id, segmento_id, pagina, limit = 5) campos_padrao.estado(@estado_uf).cidade(@cidade_id).bairro(bairro_id).segmento(@segmento_id).joins.paginate(:per_page => limit, :page => pagina) end named_scope :campos_padrao, lambda { |*args| { :select=> (args.first || "anuncios.codcli, anuncios.codseg, anuncios.nomefanta, anuncios.irmao, anuncios.endereco, anuncios.num, anuncios.complemento, anuncios.cep, anuncios.bairro, anuncios.cidade, anuncios.uf, anuncios.fone, anuncios.fax, anuncios.email, anuncios.site, anuncios.descricao, anuncios.fig_anuncio, anuncios.contrato, anuncios.uf_anunciar, anuncios.permalink, cidades.cidade as cidade_nome, estados.nome as estado_nome, segmentos.nome as segmento ") } } named_scope :segmento, lambda { |*args| if (args.first != "todos_segmentos") { :conditions => ["anuncios.codseg = ?", args.first] } else { } end } named_scope :estado, lambda { |*args| { :conditions => ["anuncios.uf = ?", args.first] } } named_scope :cidade, lambda { |*args| if (args.first != "todas_cidades") { :conditions => ["anuncios.cidade = ?", args.first] } else { } end } named_scope :bairro, lambda { |*args| if (args.first != "todos_bairros") { :conditions => ["anuncios.bairro LIKE ?", "%#{args.first}%"] } else { } end } @@@ I get this error. ctiveRecord::StatementInvalid (Mysql::Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' anuncios.codseg, anuncios.nomefanta, ' at line 1: SELECT count(anuncios.codcli, anuncios.codseg, anuncios.nomefanta, anuncios.irmao, anuncios.endereco, anuncios.num, anuncios.complemento, anuncios.cep, anuncios.bairro, anuncios.cidade, anuncios.uf, anuncios.fone, anuncios.fax, anuncios.email, anuncios.site, anuncios.descricao, anuncios.fig_anuncio, anuncios.contrato, anuncios.uf_anunciar, anuncios.permalink, cidades.cidade as cidade_nome, estados.nome as estado_nome, segmentos.nome as segmento ) AS count_anuncios_codcli_anuncios_codseg_anuncios_nomefanta_anuncios_irmao_anuncios_endereco_anuncios_num_anuncios_complemento_anuncios_cep_anuncios_bairro_anuncios_cidade_anuncios_uf_anuncios_fone_anuncios_fax_anuncios_email_anuncios_site_anuncios_descricao FROM `anuncios` INNER JOIN `estados` ON `estados`.uf = `anuncios`.uf INNER JOIN `cidades` ON `cidades`.codcid = `anuncios`.cidade INNER JOIN `segmentos` ON `segmentos`.codseg = `anuncios`.codseg WHERE (anuncios.uf = 'AC') ): /Library/Ruby/Gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:223:in `wp_count' /Library/Ruby/Gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:235:in `call' /Library/Ruby/Gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:235:in `wp_count' /Library/Ruby/Gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:85:in `paginate' /Library/Ruby/Gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/collection.rb:87:in `create' /Library/Ruby/Gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:76:in `paginate' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope' (__DELEGATION__):2:in `__send__' (__DELEGATION__):2:in `with_scope'

<div>I have this code <pre><code> def self.completa(estado_id, cidade_id, bairro_id, segmento_id, pagina, limit = 5) campos_padrao.estado(@estado_uf).cidade(@cidade_id).bairro(bairro_id).segmento(@segmento_id).joins.paginate(:per_page => limit, :page => pagina) end named_scope :campos_padrao, lambda { |*args| { :select=> (args.first || "anuncios.codcli, anuncios.codseg, anuncios.nomefanta, anuncios.irmao, anuncios.endereco, anuncios.num, anuncios.complemento, anuncios.cep, anuncios.bairro, anuncios.cidade, anuncios.uf, anuncios.fone, anuncios.fax, anuncios.email, anuncios.site, anuncios.descricao, anuncios.fig_anuncio, anuncios.contrato, anuncios.uf_anunciar, anuncios.permalink, cidades.cidade as cidade_nome, estados.nome as estado_nome, segmentos.nome as segmento ") } } named_scope :segmento, lambda { |*args| if (args.first != "todos_segmentos") { :conditions => ["anuncios.codseg = ?", args.first] } else { } end } named_scope :estado, lambda { |*args| { :conditions => ["anuncios.uf = ?", args.first] } } named_scope :cidade, lambda { |*args| if (args.first != "todas_cidades") { :conditions => ["anuncios.cidade = ?", args.first] } else { } end } named_scope :bairro, lambda { |*args| if (args.first != "todos_bairros") { :conditions => ["anuncios.bairro LIKE ?", "%#{args.first}%"] } else { } end } </code></pre> I get this error. ctiveRecord::StatementInvalid (Mysql::Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' <pre> <code> anuncios.codseg, anuncios.nomefanta, ' at line 1: SELECT count(anuncios.codcli, anuncios.codseg, anuncios.nomefanta, anuncios.irmao, anuncios.endereco, anuncios.num, anuncios.complemento, anuncios.cep, anuncios.bairro, anuncios.cidade, anuncios.uf, anuncios.fone, anuncios.fax, anuncios.email, anuncios.site, anuncios.descricao, anuncios.fig_anuncio, anuncios.contrato, anuncios.uf_anunciar, anuncios.permalink, cidades.cidade as cidade_nome, estados.nome as estado_nome, segmentos.nome as segmento ) AS count_anuncios_codcli_anuncios_codseg_anuncios_nomefanta_anuncios_irmao_anuncios_endereco_anuncios_num_anuncios_complemento_anuncios_cep_anuncios_bairro_anuncios_cidade_anuncios_uf_anuncios_fone_anuncios_fax_anuncios_email_anuncios_site_anuncios_descricao FROM `anuncios` INNER JOIN `estados` ON `estados`.uf = `anuncios`.uf INNER JOIN `cidades` ON `cidades`.codcid = `anuncios`.cidade INNER JOIN `segmentos` ON `segmentos`.codseg = `anuncios`.codseg WHERE (anuncios.uf = 'AC') ): </code> </pre> /Library/Ruby/Gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:223:in <code>wp_count' /Library/Ruby/Gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:235:in</code>call' /Library/Ruby/Gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:235:in <code>wp_count' /Library/Ruby/Gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:85:in</code>paginate' /Library/Ruby/Gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/collection.rb:87:in <code>create' /Library/Ruby/Gems/1.8/gems/mislav-will_paginate-2.3.8/lib/will_paginate/finder.rb:76:in</code>paginate' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope' (DELEGATION):2:in <code>__send__' (__DELEGATION__):2:in</code>with_scope'</div>

192

true

2008-05-14T11:06:20+02:00

18232

219 activerecord-statementinvalid-when-using-custom-select-and-having 88

17958

invalid will_paginate ActiveRecord::StatementInvalid when using custom select and having

2009-03-13T23:17:19+01:00

23331

Greg

asherwood

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/219

When using a custom select statement like the one provided in the following example @results = Page.paginate(:all, :select => "pages.*, ((ACOS(SIN(#{location.geom.y} * PI() / 180) * SIN(Y(GeomFromText( AsText(try_outs.geom))) * PI() / 180) + COS(#{location.geom.y} * PI() / 180) * COS(Y(GeomFromText( AsText(try_outs.geom))) * PI() / 180) * COS((#{location.geom.x} - X(GeomFromText( AsText(try_outs.geom)))) * PI() / 180)) * 180 / PI()) * 60 * 1.1515) AS distance ", :group => 'pages.id HAVING distance < 300', :page => params[:page], :per_page => 5) An error is thrown due to will_paginate doing this SELECT count(*) AS count_all, pages.id HAVING distance < 300 AS pages_id_having_distance_300

<div> When using a custom select statement like the one provided in the following example @results = Page.paginate(:all, :select => "pages.*, ((ACOS(SIN(#{location.geom.y} * PI() / 180) * SIN(Y(GeomFromText( AsText(try_outs.geom))) * PI() / 180) + COS(#{location.geom.y} * PI() / 180) * COS(Y(GeomFromText( AsText(try_outs.geom))) * PI() / 180) * COS((#{location.geom.x} - X(GeomFromText( AsText(try_outs.geom)))) * PI() / 180)) * 180 / PI()) * 60 * 1.1515) AS distance ", :group => 'pages.id HAVING distance < 300', :page => params[:page], :per_page => 5) An error is thrown due to will_paginate doing this SELECT count(*) AS count_all, pages.id HAVING distance < 300 AS pages_id_having_distance_300 </div>

192

false

2009-03-03T19:07:55+01:00

45858

264 incorrect-counts-when-using-rails-23-having-option-and-scopes 116

17958

open Incorrect counts when using rails 2.3 :having option and scopes

2009-03-03T19:10:44+01:00

192

Mislav

Blane Dabney

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/264

I'm using rails 2.3 and have a named_scope that uses the :having option to filter results based on joined aggregate data. When using will_paginate with this, the :having (and :group) options from the scope are not passed through to the count method, so the page count it calculates is inaccurate. I have attached the patch I made to resolve this. It probably needs some work but it resolved my immediate need. It basically ensures that the :having and :group options are pulled from the scope and ONLY if they weren't explicity defined when calling paginate.

<div>I'm using rails 2.3 and have a named_scope that uses the :having option to filter results based on joined aggregate data. When using will_paginate with this, the :having (and :group) options from the scope are not passed through to the count method, so the page count it calculates is inaccurate. I have attached the patch I made to resolve this. It probably needs some work but it resolved my immediate need. It basically ensures that the :having and :group options are pulled from the scope and ONLY if they weren't explicity defined when calling paginate.</div>

192

false

2009-02-11T18:35:48+01:00

47072

263 wrong-count-results 115

17958

new count wrong count results

2009-02-12T09:43:29+01:00

47072

friofool

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/263

hi, this is my log : SQL (3.1ms) SELECT count(*) AS count_all, mifo.mod_icom_option_id,mip.id AS mifo_mod_icom_option_id_mip_id FROM `mod_icom_files_options` as mifo inner join mod_icom_prods as mip on (mifo.mod_icom_prod_id = mip.id) inner join mod_icom_marque_prods as mimp on (mip.id = mimp.mod_icom_prod_id) where mip.visibilite_prod = 1 AND mip.statut_promo !='destockage' and mifo.valide = 1 and mip.visibilite_prod = 1 and mimp.mod_icom_marque_id = 45 GROUP BY mifo.mod_icom_option_id,mip.id If i tun this query in sql database client i found 28 results but the count method return 18 records (i add a logger in the wp_count method). I set the :per_page => 9, and the view method display 2 pages. But if i try to change manually the page number parameter in the url to 3, the helper show me 4 pages who is the correct value. Is there a bug ?

<div>hi, this is my log : SQL (3.1ms) SELECT count(*) AS count_all, mifo.mod_icom_option_id,mip.id AS mifo_mod_icom_option_id_mip_id FROM <code>mod_icom_files_options</code> as mifo inner join mod_icom_prods as mip on (mifo.mod_icom_prod_id = mip.id) inner join mod_icom_marque_prods as mimp on (mip.id = mimp.mod_icom_prod_id) where mip.visibilite_prod = 1 AND mip.statut_promo !='destockage' and mifo.valide = 1 and mip.visibilite_prod = 1 and mimp.mod_icom_marque_id = 45 GROUP BY mifo.mod_icom_option_id,mip.id If i tun this query in sql database client i found 28 results but the count method return 18 records (i add a logger in the wp_count method). I set the :per_page => 9, and the view method display 2 pages. But if i try to change manually the page number parameter in the url to 3, the helper show me 4 pages who is the correct value. Is there a bug ?</div>

192

true

2008-12-10T03:37:55+01:00

40294

255 paginate-very-slow-on-large-queries-with-group 107

17958

resolved paginate very slow on large queries with :group

2009-02-06T01:32:15+01:00

192

Mislav

Michael Ragalie

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/255

In finder.rb, wp_count() passes off to count() in order to figure out how many total results exist. When :group is specified, count() uses execute_grouped_calculation() in ActiveRecord::Calculations, which calls ActiveSupport::OrderedHash[]= . ActiveSupport::OrderedHash[]= calls assoc() on the its internal Array, which compares the value passed to assoc() to the first value of each array within its internal Array. As a result, for my application, which has a total of 2,895 matching rows, a total of 4,189,065 == comparisons are made in the course of determining the number of rows. This is obviously very slow. Is there be a faster way to calculate the number of rows for queries with :group?

<div>In finder.rb, wp_count() passes off to count() in order to figure out how many total results exist. When :group is specified, count() uses execute_grouped_calculation() in ActiveRecord::Calculations, which calls ActiveSupport::OrderedHash[]= . ActiveSupport::OrderedHash[]= calls assoc() on the its internal Array, which compares the value passed to assoc() to the first value of each array within its internal Array. As a result, for my application, which has a total of 2,895 matching rows, a total of 4,189,065 == comparisons are made in the course of determining the number of rows. This is obviously very slow. Is there be a faster way to calculate the number of rows for queries with :group?</div>

192

false

2009-01-29T08:10:02+01:00

15518

262 behavior-of-view-helper-is-incorrect-if-url-includes 114

17958

open html url view will_paginate Behavior of view helper is incorrect if URL includes "@"

2009-01-30T08:17:10+01:00

15518

Anton Ageev

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/262

Given: * Rails 2.1.2 * will_paginate 2.3.6 config/routes.rb: @@@ ruby ActionController::Routing::Routes.draw do |map| RE_USER_LOGIN = /[^\/]+/ map.with_options :controller => "user_blogs", :action => "index" do |r| r.connect "blogs/:user_login/pages/:page", :requirements => { :user_login => RE_USER_LOGIN } r.connect "blogs/:user_login", :requirements => { :user_login => RE_USER_LOGIN } end .... end @@@ app/views/user_blogs/index.html.erb: @@@ ... <%= will_paginate @news %> ... @@@ I get page links "/blogs/2Andrex/pages/@", "/blogs/3Andrex/pages/@" when I visited "/blogs/@Andrex". The routing works fine: @@@ $ ./script/console >> irb ActionController::Routing::Routes irb: warn: can't alias context from irb_context. >> recognize_path "/blogs/@Andrex/pages/2" => {:user_login=>"@Andrex", :controller=>"user_blogs", :page=>"2", :action=>"index"} >> generate :user_login=>"@Andrex", :controller=>"user_blogs", :page=>"2", :action=>"index" => "/blogs/@Andrex/pages/2" @@@

<div>Given: * Rails 2.1.2 * will_paginate 2.3.6 config/routes.rb: <pre><code class="ruby"> ActionController::Routing::Routes.draw do |map| RE_USER_LOGIN = /[^\/]+/ map.with_options :controller => "user_blogs", :action => "index" do |r| r.connect "blogs/:user_login/pages/:page", :requirements => { :user_login => RE_USER_LOGIN } r.connect "blogs/:user_login", :requirements => { :user_login => RE_USER_LOGIN } end .... end </code></pre> app/views/user_blogs/index.html.erb: <pre><code> ... <%= will_paginate @news %> ... </code></pre> I get page links "/blogs/2Andrex/pages/@", "/blogs/3Andrex/pages/@" when I visited "/blogs/@Andrex". The routing works fine: <pre><code> $ ./script/console >> irb ActionController::Routing::Routes irb: warn: can't alias context from irb_context. >> recognize_path "/blogs/@Andrex/pages/2" => {:user_login=>"@Andrex", :controller=>"user_blogs", :page=>"2", :action=>"index"} >> generate :user_login=>"@Andrex", :controller=>"user_blogs", :page=>"2", :action=>"index" => "/blogs/@Andrex/pages/2" </code></pre></div>

192

true

2009-01-14T19:33:35+01:00

41565

260 incorrect-set-of-records-returned-when-using-order-on-a-field-with-little-variation 112

17958

resolved id mssql order sort incorrect set of records returned when using order on a field with little variation

2009-01-16T12:13:21+01:00

192

Mislav

ReggieB

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/260

I think I have found a bug this time :o) . However, it may be a MS SQL only error as I haven't tested the problem with MySQL. I have a table of "support cases" and each case can have a status of one of five options (e.g. 'open', 'closed', 'suspended' etc.). If I sort by the case status in a paginated view I get records repeated on different pages and some records don't appear at all. The correct total of records is always shown. I believe I have found the problem: it is the way will_paginate pulls out the small number of records it needs for a single page view. If you have a page size of 20 and 65 records total, to get the page two records it first pulls out the first 40 records (order DESC), then flips them over (order ASC) and pulls the first 20 records, then flips them over again (order DESC) to present the set of 20 records in the desired order. This works fine if the field you are sorting on is unique for each record, but falls down if you have a lot of records with the same field value. SQL seems to be inconsistent in the ordering of individual records within one unique field value. That is the order of ten records with the status "open" sorted using "order DESC" don't seem to be mirror images of the same records when you do the next "order ASC" step. That is, they may be 1,2,3,4,5,6,7,8,9,10 on the "order DESC" but may well be 10,8,7,3,4,5,1,2,9,6 on next "order ASC" This results in inconsistency when you reorder the records and remove some at each step. What seems to fix the problem is if you add a field to the sort that is unique for each record. id is the obvious one. So @@@ SupportCase.paginate(:page => params[:page], :per_page => 20, :order => "order DESC" @@@ Results in inconsistent behaviour. @@@ SupportCase.paginate(:page => params[:page], :per_page => 20, :order => "order DESC, id DESC" @@@ Creates the correct results. I suggest you append ", id DESC" to then end of all order statements unless id is already used in the sort.

<div>I think I have found a bug this time :o) . However, it may be a MS SQL only error as I haven't tested the problem with MySQL. I have a table of "support cases" and each case can have a status of one of five options (e.g. 'open', 'closed', 'suspended' etc.). If I sort by the case status in a paginated view I get records repeated on different pages and some records don't appear at all. The correct total of records is always shown. I believe I have found the problem: it is the way will_paginate pulls out the small number of records it needs for a single page view. If you have a page size of 20 and 65 records total, to get the page two records it first pulls out the first 40 records (order DESC), then flips them over (order ASC) and pulls the first 20 records, then flips them over again (order DESC) to present the set of 20 records in the desired order. This works fine if the field you are sorting on is unique for each record, but falls down if you have a lot of records with the same field value. SQL seems to be inconsistent in the ordering of individual records within one unique field value. That is the order of ten records with the status "open" sorted using "order DESC" don't seem to be mirror images of the same records when you do the next "order ASC" step. That is, they may be 1,2,3,4,5,6,7,8,9,10 on the "order DESC" but may well be 10,8,7,3,4,5,1,2,9,6 on next "order ASC" This results in inconsistency when you reorder the records and remove some at each step. What seems to fix the problem is if you add a field to the sort that is unique for each record. id is the obvious one. So <pre><code> SupportCase.paginate(:page => params[:page], :per_page => 20, :order => "order DESC" </code></pre> Results in inconsistent behaviour. <pre><code> SupportCase.paginate(:page => params[:page], :per_page => 20, :order => "order DESC, id DESC" </code></pre> Creates the correct results. I suggest you append ", id DESC" to then end of all order statements unless id is already used in the sort.</div>

192

false

2009-01-12T21:46:38+01:00

43348

259 ignores-page-params-in-merb 111

17958

new agnostic merb url Ignores page :params in merb

2009-01-14T00:38:57+01:00

192

Mislav

Jamie Wilson

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/259

Using the agnostic branch. Trying to pass in explicit url params, which seem to be ignored when using will_paginate under merb. I think doing something like @@@ def url(page) params = @template.request.params.except(:action, :controller).merge('page' => page) params.merge!(@options[:params]) if @options[:params] @template.url(params) end @@@ fixes the problem. There's quite probably a better way to do it though. Thanks.

<div>Using the agnostic branch. Trying to pass in explicit url params, which seem to be ignored when using will_paginate under merb. I think doing something like <pre><code> def url(page) params = @template.request.params.except(:action, :controller).merge('page' => page) params.merge!(@options[:params]) if @options[:params] @template.url(params) end </code></pre> fixes the problem. There's quite probably a better way to do it though. Thanks.</div>

192

true

2008-12-22T14:24:53+01:00

41565

257 order-by-not-working-with-joined-tables 109

17958

invalid join sort order by not working with joined tables

2009-01-08T15:33:17+01:00

192

Mislav

ReggieB

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/257

I'm currently using Rails 2.1 and was using will_paginate 2.2.2. I've upgraded to mislav-will_paginate 2.3.6, but the problem persists. MS SQL 2005 database. # The problem # I am listing information from a CRM system. The listing pulls information from three tables. To maximise performance I'm joining the tables. This works fine, until I try to order the results. will_paginate seems to grab the order text and then escapes out the period used to identify which table the sort element belongs to. So: @@@ORDER BY c.company_name @@@ becomes @@@ORDER BY c\.company_name @@@ Which leads to a SQL error. As I am using MS SQL I also use square brackets in my code and these are also escaped out: @@@ORDER BY \[c\]\.\[company_name\] @@@ It is not the core SQL query where this occurs, but rather the encapsulating tmp1 and tmp2 entries. Here is my code @@@ @opportunities = WillPaginate::Collection.create(page, per_page) do |pager| result = Opportunity.find(:all, :select => " [o].*, [c].[Comp_Name] AS company_name, [p].[Pers_Salutation] AS person_salutation, [p].[Pers_FirstName] AS person_first_name, [p].[Pers_LastName] AS person_last_name, [u].[User_FirstName] AS user_first_name, [u].[User_LastName] AS user_last_name ", :conditions => conditions.join(" AND "), :joins => " AS [o] LEFT JOIN [Company] AS [c] ON [o].[Oppo_PrimaryCompanyId] = [c].[Comp_CompanyId] LEFT JOIN [Person] AS [p] ON [o].[Oppo_PrimaryPersonId] = [p].[Pers_PersonId] LEFT JOIN [Users] AS [u] ON [o].[Oppo_AssignedUserId] = [u].[User_UserId] ", :order => 'c.comp_name', :limit => pager.per_page, :offset => pager.offset) # inject the result array into the paginated collection: pager.replace(result) unless pager.total_entries # the pager didn't manage to guess the total count, do it manually pager.total_entries = Opportunity.count(:all, :conditions => conditions.join(" AND ")) end end @@@ This works fine if you comment out the :order line, but fails as it is above. The SQL error this generates is here: @@@DBI::DatabaseError: Execute OLE error code:80040E14 in Microsoft OLE DB Provider for SQL Server Incorrect syntax near '\.'. HRESULT error code:0x80020009 Exception occurred.: SELECT * FROM (SELECT TOP 20 * FROM (SELECT TOP 20 [o].*, [c].[Comp_Name] AS company_name, [p].[Pers_Salutation] AS person_salutation, [p].[Pers_FirstName] AS person_first_name, [p].[Pers_LastName] AS person_last_name, [u].[User_FirstName] AS user_first_name, [u].[User_LastName] AS user_last_name FROM Opportunity AS [o] LEFT JOIN [Company] AS [c] ON [o].[Oppo_PrimaryCompanyId] = [c].[Comp_CompanyId] LEFT JOIN [Person] AS [p] ON [o].[Oppo_PrimaryPersonId] = [p].[Pers_PersonId] LEFT JOIN [Users] AS [u] ON [o].[Oppo_AssignedUserId] = [u].[User_UserId] WHERE (Oppo_CreatedDate < '2008-12-01 00:00:00' AND Oppo_CreatedDate > '2008-11-01 00:00:00') ORDER BY c.comp_name) AS tmp1 ORDER BY c\.\[comp_name\] DESC) AS tmp2 ORDER BY c\.\[comp_name\] @@@ As you can see, the problem is shown right at the end of the error message

<div>I'm currently using Rails 2.1 and was using will_paginate 2.2.2. I've upgraded to mislav-will_paginate 2.3.6, but the problem persists. MS SQL 2005 database. <h1>The problem</h1> I am listing information from a CRM system. The listing pulls information from three tables. To maximise performance I'm joining the tables. This works fine, until I try to order the results. will_paginate seems to grab the order text and then escapes out the period used to identify which table the sort element belongs to. So: @@@ORDER BY c.company_name <pre><code> becomes @@@ORDER BY c\.company_name </code></pre> Which leads to a SQL error. As I am using MS SQL I also use square brackets in my code and these are also escaped out: @@@ORDER BY [c].[company_name] <pre><code> It is not the core SQL query where this occurs, but rather the encapsulating tmp1 and tmp2 entries. Here is my code @@@ @opportunities = WillPaginate::Collection.create(page, per_page) do |pager| result = Opportunity.find(:all, :select => " [o].*, [c].[Comp_Name] AS company_name, [p].[Pers_Salutation] AS person_salutation, [p].[Pers_FirstName] AS person_first_name, [p].[Pers_LastName] AS person_last_name, [u].[User_FirstName] AS user_first_name, [u].[User_LastName] AS user_last_name ", :conditions => conditions.join(" AND "), :joins => " AS [o] LEFT JOIN [Company] AS [c] ON [o].[Oppo_PrimaryCompanyId] = [c].[Comp_CompanyId] LEFT JOIN [Person] AS [p] ON [o].[Oppo_PrimaryPersonId] = [p].[Pers_PersonId] LEFT JOIN [Users] AS [u] ON [o].[Oppo_AssignedUserId] = [u].[User_UserId] ", :order => 'c.comp_name', :limit => pager.per_page, :offset => pager.offset) # inject the result array into the paginated collection: pager.replace(result) unless pager.total_entries # the pager didn't manage to guess the total count, do it manually pager.total_entries = Opportunity.count(:all, :conditions => conditions.join(" AND ")) end end </code></pre> This works fine if you comment out the :order line, but fails as it is above. The SQL error this generates is here: @@@DBI::DatabaseError: Execute <pre> <code>OLE error code:80040E14 in Microsoft OLE DB Provider for SQL Server Incorrect syntax near '\.'. HRESULT error code:0x80020009 Exception occurred.: SELECT * FROM (SELECT TOP 20 * FROM (SELECT TOP 20 </code> </pre> [o].*, [c].[Comp_Name] AS company_name, [p].[Pers_Salutation] AS person_salutation, [p].[Pers_FirstName] AS person_first_name, [p].[Pers_LastName] AS person_last_name, [u].[User_FirstName] AS user_first_name, [u].[User_LastName] AS user_last_name FROM Opportunity AS [o] LEFT JOIN [Company] AS [c] ON [o].[Oppo_PrimaryCompanyId] = [c].[Comp_CompanyId] LEFT JOIN [Person] AS [p] ON [o].[Oppo_PrimaryPersonId] = [p].[Pers_PersonId] LEFT JOIN [Users] AS [u] ON [o].[Oppo_AssignedUserId] = [u].[User_UserId] WHERE (Oppo_CreatedDate < '2008-12-01 00:00:00' AND Oppo_CreatedDate > '2008-11-01 00:00:00') ORDER BY c.comp_name) AS tmp1 ORDER BY c.[comp_name] DESC) AS tmp2 ORDER BY c.[comp_name] <pre><code> As you can see, the problem is shown right at the end of the error message </code></pre></div>

192

true

2008-12-31T19:31:39+01:00

37100

258 rails-22x-the-binding-argument-of-concat-is-no-longer-needed 110

17958

duplicate concat deprecation paginate_section Rails 2.2.x the binding argument of concat is no longer needed

2009-01-08T15:20:56+01:00

192

Mislav

John Small

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/258

Working in mislav-will_paginate 2.3.6 and Rails 2.2.2 when calling paginated_section you'll get an error on line 145 with a deprecation warning. This;- <pre> def paginated_section(*args, &block) pagination = will_paginate(*args).to_s content = pagination + capture(&block) + pagination (line 145) concat content, block.binding end </pre> needs to be changed to;- <pre> def paginated_section(*args, &block) pagination = will_paginate(*args).to_s content = pagination + capture(&block) + pagination concat content end </pre> The extra argument to concat has been removed from Rails 2.2.x

<div>Working in mislav-will_paginate 2.3.6 and Rails 2.2.2 when calling paginated_section you'll get an error on line 145 with a deprecation warning. This;- def paginated_section(*args, &block) <pre> <code> pagination = will_paginate(*args).to_s content = pagination + capture(&block) + pagination </code> </pre> (line 145) concat content, block.binding <pre> <code>end </code> </pre> needs to be changed to;- def paginated_section(*args, &block) <pre> <code> pagination = will_paginate(*args).to_s content = pagination + capture(&block) + pagination concat content end </code> </pre> The extra argument to concat has been removed from Rails 2.2.x</div>

192

true

2008-12-21T19:30:06+01:00

38488

256 double-page-params-when-using-merb-1061 108

17958

resolved Double page params when using merb 1.0.6.1

2008-12-21T20:06:49+01:00

192

Mislav

phatmann

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/256

In merb 1.0.6.1, the page links are not being formed correctly after browsing to page 2, 3, etc. The links end up with double page params: /foo?page=2&page=5 The fix is to change line 8 in merb.rb params = @template.request.params.except(:action, :controller).merge(:page => page) TO params = @template.request.params.except(:action, :controller).merge('page' => page)

<div>In merb 1.0.6.1, the page links are not being formed correctly after browsing to page 2, 3, etc. The links end up with double page params: /foo?page=2&page=5 The fix is to change line 8 in merb.rb params = @template.request.params.except(:action, :controller).merge(:page => page) TO params = @template.request.params.except(:action, :controller).merge('page' => page)</div>

192

true

2008-05-16T03:50:13+02:00

6848

220 has-many-through-causes-stack-level-too-deep-error 89

17958

resolved edge gem will_paginate has many :through causes "Stack level too deep error"

2008-12-17T01:14:32+01:00

18996

Roger

iamjwc (at gmail)

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/220

@@@ ruby class Program < AR::Base has_many :sessions, :through => :component end Program.find(:first).sessions # => [#<Session:...>, #<Session:...>] Program.find(:first).sessions.first # throws SystemStackError "stack level too deep" @@@ *Stack Trace* RAILS_ROOT/vendor/plugins/will_paginate/lib/will_paginate/finder.rb:92:in `method_missing_without_paginate' RAILS_ROOT/vendor/plugins/will_paginate/lib/will_paginate/finder.rb:93:in `method_missing'

<div><pre><code class="ruby">class Program < AR::Base has_many :sessions, :through => :component end Program.find(:first).sessions # => [#<Session:...>, #<Session:...>] Program.find(:first).sessions.first # throws SystemStackError "stack level too deep" </code></pre> Stack Trace RAILS_ROOT/vendor/plugins/will_paginate/lib/will_paginate/finder.rb:92:in `method_missing_without_paginate' RAILS_ROOT/vendor/plugins/will_paginate/lib/will_paginate/finder.rb:93:in `method_missing' </div>

192

false

2008-12-08T21:10:57+01:00

14649

254 chaining-named-scopes-with-paginate-doesnt-work-with-ms-sql-server 106

17958

new activerecord-sqlserver-adapter mssql named_scope sqlserver will_paginate Chaining named scopes with paginate doesn't work with MS SQL Server

2008-12-10T16:15:37+01:00

14649

Jon Canady

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/254

Using activerecord-sqlserver-adapter (1.0.0) and Rails 2.2.2. Set up some nice named scopes to do things like filter by user_id and status, and then chained these together with the paginate scope, but I always get the first set of results regardless of the :page parameter. However, if I code up a quick method that hacks together the :conditions parameter and call paginate manually (sans-named-scope) it seems to work fine. Code is here: http://pastie.org/334222 For the #search method, the following SQL is being executed (for page 6): SELECT * FROM (SELECT TOP 10 * FROM (SELECT TOP 60 * FROM [TReport] WHERE (userid = '3303461' ) ORDER BY last_name) AS tmp1 ORDER BY last_name DESC) AS tmp2 ORDER BY last_name This works. The following SQL is being generated for the named parameters, obviously wrong: SELECT * FROM (SELECT TOP 10 * FROM (SELECT TOP 60 * FROM [T_PAExtensions2009] WHERE (( first_name LIKE '%' OR last_name LIKE '%' OR member_id LIKE '%') AND (ncpdp = '3303461')) ORDER BY last_name) AS tmp1 ) AS tmp2 Is this an issue with activerecord-sqlserver-adapter or will_paginate?

<div>Using activerecord-sqlserver-adapter (1.0.0) and Rails 2.2.2. Set up some nice named scopes to do things like filter by user_id and status, and then chained these together with the paginate scope, but I always get the first set of results regardless of the :page parameter. However, if I code up a quick method that hacks together the :conditions parameter and call paginate manually (sans-named-scope) it seems to work fine. Code is here: <a href="http://pastie.org/334222">http://pastie.org/334222</a> For the #search method, the following SQL is being executed (for page 6): SELECT * FROM (SELECT TOP 10 * FROM (SELECT TOP 60 * FROM [TReport] WHERE (userid = '3303461' ) ORDER BY last_name) AS tmp1 ORDER BY last_name DESC) AS tmp2 ORDER BY last_name This works. The following SQL is being generated for the named parameters, obviously wrong: SELECT * FROM (SELECT TOP 10 * FROM (SELECT TOP 60 * FROM [T_PAExtensions2009] WHERE (( first_name LIKE '%' OR last_name LIKE '%' OR member_id LIKE '%') AND (ncpdp = '3303461')) ORDER BY last_name) AS tmp1 ) AS tmp2 Is this an issue with activerecord-sqlserver-adapter or will_paginate?</div>

192

true

2008-09-24T16:52:26+02:00

32908

247 will_paginate-helper-doesnt-work-with-has_and_belongs_to_many-associations 99

17958

invalid will_paginate will_paginate helper doesn't work with has_and_belongs_to_many associations.

2008-12-09T16:00:40+01:00

192

Mislav

Dipesh Batheja

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/247

Here is how my Product model looks like: class Product < ActiveRecord::Base has_and_belongs_to_many :categories, :join_table => "products_categories" end In my controller, i have done this: @products = @current_category.products.paginate :per_page => 12, :page => params[:page] will_paginate helper doesn't show pages in the view. If manually pass page param in url, it work just fine. But will_paginate helper does not show the pages list and next and prev links.

<div>Here is how my Product model looks like: class Product < ActiveRecord::Base has_and_belongs_to_many :categories, :join_table => "products_categories" end In my controller, i have done this: @products = @current_category.products.paginate :per_page => 12, :page => params[:page] will_paginate helper doesn't show pages in the view. If manually pass page param in url, it work just fine. But will_paginate helper does not show the pages list and next and prev links.</div>

192

true

2008-11-24T23:01:20+01:00

38770

253 visible_page_numbers-is-on-where-n-is-the-number-of-pages 105

17958

resolved visible_page_numbers is O(n) where n is the number of pages

2008-11-25T00:42:45+01:00

192

Mislav

Lida Tang

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/253

visible_page_numbers will take a very long time if the number of pages you have is large, say if you are returning web search results that have millions of pages. Here is the offending code: visible = (1..total_pages).to_a <<< O(n) left_gap = (2 + outer_window)...window_from right_gap = (window_to + 1)...(total_pages - outer_window) <<< Again visible -= left_gap.to_a if left_gap.last - left_gap.first > 1 visible -= right_gap.to_a if right_gap.last - right_gap.first > 1 Here is a potential fix that only depend on the size of inner+outer window: # these are always visible visible = (window_from..window_to).to_a # left window if window_from > (outer_window + 1) # fully visible visible = ((1..(outer_window+1)).to_a + visible) else # runs into visible pages visible = (1...window_from).to_a + visible end # right window if window_to < (total_pages - outer_window) # fully visible visible = (visible + (total_pages - outer_window..total_pages).to_a) else # runs into visible pages visible = visible + ((window_to+1)..total_pages).to_a end

<div>visible_page_numbers will take a very long time if the number of pages you have is large, say if you are returning web search results that have millions of pages. Here is the offending code: <pre> <code> visible = (1..total_pages).to_a <<< O(n) left_gap = (2 + outer_window)...window_from right_gap = (window_to + 1)...(total_pages - outer_window) <<< Again visible -= left_gap.to_a if left_gap.last - left_gap.first > 1 visible -= right_gap.to_a if right_gap.last - right_gap.first > 1 </code> </pre> Here is a potential fix that only depend on the size of inner+outer window: <pre> <code># these are always visible visible = (window_from..window_to).to_a # left window if window_from > (outer_window + 1) # fully visible visible = ((1..(outer_window+1)).to_a + visible) else # runs into visible pages visible = (1...window_from).to_a + visible end # right window if window_to < (total_pages - outer_window) # fully visible visible = (visible + (total_pages - outer_window..total_pages).to_a) else # runs into visible pages visible = visible + ((window_to+1)..total_pages).to_a end </code> </pre></div>

192

true

2008-11-07T05:05:07+01:00

36733

252 fwd-git-merge-braidtrack-hit-fatal-not-a-git-repository 104

17958

invalid git merge braid/track hit Fatal: Not a git repository

2008-11-07T12:39:32+01:00

192

Mislav

up1notch

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/252

Encounter the following issue during installation of will_paginate: When trying to run the command: git merge braid/track in the dos prompt, it throw the following error: Fatal: Not a git repository. I am using Windows Vista, could this be the coz? Any solution? So I tried to install rails v2.1.2 so that I can use the "ruby script/plugin ..." command to do the same job, but it pop-up an error windows with the following error: The procedure entry point_apr_hash_clear@4 could not be located in the dynamic link library libapr_tsvn.dll. When I close the error window, another window pop-up that says: SVN_FILE_DESCRIPTION has stopped working...Windows searching for solution. This is the same error i encounter when trying to run "svn.exe" directly in my DOS prompt. Hope you can help; I am stuck on pagination for 2 days. Thanks in advance.

<div>Encounter the following issue during installation of will_paginate: When trying to run the command: <pre> <code>git merge braid/track </code> </pre> in the dos prompt, it throw the following error: <pre> <code>Fatal: Not a git repository. </code> </pre> I am using Windows Vista, could this be the coz? Any solution? So I tried to install rails v2.1.2 so that I can use the "ruby script/plugin ..." command to do the same job, but it pop-up an error windows with the following error: <pre> <code>The procedure entry point_apr_hash_clear@4 could not be located in </code> </pre> the dynamic link library libapr_tsvn.dll. When I close the error window, another window pop-up that says: <pre> <code>SVN_FILE_DESCRIPTION has stopped working...Windows searching for </code> </pre> solution. This is the same error i encounter when trying to run "svn.exe" directly in my DOS prompt. Hope you can help; I am stuck on pagination for 2 days. Thanks in advance.</div>

192

true

2008-10-30T01:58:28+01:00

17482

251 do-you-still-need-activesupport-as-a-gem-dependency-it-breaks-stuff 103

17958

resolved Do you still need activesupport as a gem dependency? It breaks stuff...

2008-10-30T12:24:29+01:00

192

Mislav

Chad Woolley

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/251

I see this ticket: http://sod.lighthouseapp.com/projects/17958/tickets/222-edge-rails-and-mislav-will_paginate-gem-don-t-work-together And this commit: http://github.com/mislav/will_paginate/commit/8a64e37757a1793a6bce3e7aed2558d1e224a2df I'm wondering if we can remove it safely now, because it causes us problems. Here is our specific problem: * We explicitly activate all gem versions before rails initializes (via config/preinitializer.rb). * We sometimes activate an older version of rails than is installed on the box (e.g. app is still using rails 2.1.0 but 2.1.1 is installed as well) * If mislav-will_paginate is activated before rails (which happens if you go in alphabetical order), the highest version of activesupport (2.1.1) will be activated. This causes the subsequent activation of rails 2.1.1 to fail, because rails 2.1.0 tries to activate activesupport 2.1.0, which fails because you can only activate one version of a gem at a time. Since will_paginate can only operate in the context of Rails, it doesn't seem to make sense for it to explicitly define a sub-dependency of rails as one of its dependencies. So, unless there is a reason to keep this dependency, can we remove it? Thanks, -- Chad

<div>I see this ticket: <a href="http://sod.lighthouseapp.com/projects/17958/tickets/222-edge-rails-and-mislav-will_paginate-gem-don-t-work-together"> http://sod.lighthouseapp.com/pro...</a> And this commit: <a href="http://github.com/mislav/will_paginate/commit/8a64e37757a1793a6bce3e7aed2558d1e224a2df"> http://github.com/mislav/will_pa...</a> I'm wondering if we can remove it safely now, because it causes us problems. Here is our specific problem: <ul> <li> We explicitly activate all gem versions before rails initializes (via config/preinitializer.rb). </li> <li> We sometimes activate an older version of rails than is installed on the box (e.g. app is still using rails 2.1.0 but 2.1.1 is installed as well) </li> <li> If mislav-will_paginate is activated before rails (which happens if you go in alphabetical order), the highest version of activesupport (2.1.1) will be activated. This causes the subsequent activation of rails 2.1.1 to fail, because rails 2.1.0 tries to activate activesupport 2.1.0, which fails because you can only activate one version of a gem at a time. </li> </ul> Since will_paginate can only operate in the context of Rails, it doesn't seem to make sense for it to explicitly define a sub-dependency of rails as one of its dependencies. So, unless there is a reason to keep this dependency, can we remove it? Thanks, -- Chad</div>

192

true

2008-10-25T04:12:03+02:00

33263

250 nomethoderror-on-first-page-multiple-associations 102

17958

invalid association associations bug include nomethoderror NoMethodError on first page (Multiple associations)

2008-10-30T10:07:24+01:00

192

Mislav

akshay (at mugasha)

Mislav

http://sod.lighthouseapp.com/projects/17958/tickets/250

Hello, I have been trying to debug this issue and then i realized that plugin was causing this. I am using the example of search from railscasts but I have a deep association model. -----ERROR--------------------------------- NoMethodError in Browses#tracks Showing app/views//tracks.html.erb where line #18 raised: You have a nil object when you didn't expect it! The error occurred while evaluating nil.setTitle Extracted source (around line #18): 15: 16: <% for track in @track do %> 17: <h3 style="margin-bottom: 2px"> => 18: <%= track.trackTitle%> - <%= track.artist.name %> (<%= track.dj_set.setTitle %>) 19: </h3> 20: <% end %> 21: --------------------------------------------- class Track belongs_to :dj_set belongs_to :artist end class dj_set has_many :tracks, :dependent => :destroy end class artist has_many :tracks end ------track.html.erb------ <% form_tag request.path, :method => 'get' do %> <% content_tag :label do %> Search Tracks: <%= text_field_tag :search, params[:search] %> <% end %> <% end %> <% for track in @track do %> <h3 style="margin-bottom: 2px"> <%= track.trackTitle%> - <%= track.artist.name %> (<%= track.dj_set.setTitle %>) </h3> <% end %> ------ Track.rb model ------- def self.search(search, page) paginate :per_page => 20, :page => page, :include => [:artist, :dj_set], :conditions => ['trackTitle like ?', "%#{search}%"], :order => 'created_at' end ----- browse_controller.rb ------ def tracks @track = Track.search(params[:search], params[:page]) end end ------------------------------ This WORKS fine on page >2 and if any search is performed. The eror is only shown on page one. Correct output Search Tracks: --intro--- Intro - A State of Trance (374) Intro - A State of Trance (375) Intro - A State of Trance (373) Intro - Trance Around the World (239) Intro - Trance Around the World (238) Thanks you! Cheers, Akshay

<div>Hello, I have been trying to debug this issue and then i realized that plugin was causing this. I am using the example of search from railscasts but I have a deep association model. -----ERROR--------------------------------- NoMethodError in Browses#tracks Showing app/views//tracks.html.erb where line <a href="/projects/17958/tickets/18" title="Ticket #18">#18</a> raised: You have a nil object when you didn't expect it! The error occurred while evaluating nil.setTitle Extracted source (around line <a href="/projects/17958/tickets/18" title="Ticket #18">#18</a>): 15: 16: <% for track in @track do %> 17: => 18: <%= track.trackTitle%> - <%= track.artist.name %> (<%= track.dj_set.setTitle %>) 19: 20: <% end %> 21: <hr> class Track belongs_to :dj_set belongs_to :artist end class dj_set has_many :tracks, :dependent => :destroy end class artist has_many :tracks end ------track.html.erb------ <% form_tag request.path, :method => 'get' do %> <% content_tag :label do %> <pre> <code>Search Tracks: <%= text_field_tag :search, params[:search] %> </code> </pre> <% end %> <% end %> <pre> <code><% for track in @track do %> <%= track.trackTitle%> - <%= track.artist.name %> (<%= track.dj_set.setTitle %>) <% end %> </code> </pre> ------ Track.rb model ------- def self.search(search, page) <pre> <code>paginate :per_page => 20, :page => page, :include => [:artist, :dj_set], :conditions => ['trackTitle like ?', "%#{search}%"], :order => 'created_at' </code> </pre> end ----- browse_controller.rb ------ def tracks <pre> <code>@track = Track.search(params[:search], params[:page]) </code> </pre> end <h2>end</h2> This WORKS fine on page >2 and if any search is performed. The eror is only shown on page one. Correct output Search Tracks: --intro--- Intro - A State of Trance (374) Intro - A State of Trance (375) Intro - A State of Trance (373) Intro - Trance Around the World (239) Intro - Trance Around the World (238) Thanks you! Cheers, Akshay</div>