#124 ✓invalid
Rob Dupuis

Change page_link_or_span api to take options

Reported by Rob Dupuis | October 3rd, 2007 @ 11:47 AM

This is a feature request to aid with overriding this method. I was wondering if the method signature for the page_link_or_span in view_helpers could be changed to take all the options instead of just the param.

This would help me in my situation, because I want to override this method in order to generate my links in some other wacky way. At the moment I pass in a custom param, check whether its the class I'm interested in and then do my logic. With the options, I could more easily pass in all the options I need and leave the default behaviour when my options aren't present.

Thanks, Rob

Comments and changes to this ticket

  • Mislav

    Mislav October 4th, 2007 @ 06:02 AM

    • Assigned user changed from “Chris Wanstrath” to “Mislav”
    • State changed from “new” to “open”

    Definitely coming. I'll be working on this soon

  • Rob Dupuis

    Rob Dupuis November 5th, 2007 @ 02:03 PM

    Things have improved with recent versions. You can now override page_or_link_span and get hold of the @options, so I'd close this ticket. Thanks.

  • Mislav

    Mislav December 24th, 2007 @ 03:20 AM

    • State changed from “open” to “invalid”

    I'm closing this ticket in favor of #165, which would solve all your problems. Watch that ticket for updates from me.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Everyone's favorite Ruby library for pagination of practically anything!

People watching this ticket

Pages