count SQL invalid on Oracle

Hm... that query is generated by ActiveRecord count method. That means the adapter for Oracle might be broken?

Does every pagination call fail? Can you paste me a simple example where this error occurs (the call to paginating finder and generated SQL for both select and count)?

Thanks

oh, so this is a problem with count query generated in paginate_by_sql ...

Well, that was bound to fail in certain adapters. The real solution is to construct your own count query, because it's very hard to do that automatically (would require parsing the original select query).

class LoggingEvent
  def self.paginate_events(search_for, page, per_page = nil)
    search_query = ["select * from #{table_name} where stack_trace like ?", "%#{search_for}%"]
    count_query = search_query.dup
    # change the original query to count
    count_query[0] = count_query[0].sub('*', 'COUNT(*)')
    # add ORDER to original select query
    search_query.first << " ORDER BY timestamp asc"

    total_entries = count_by_sql(count_query)
    paginate_by_sql(search_query, :page => page, :per_page => per_page, :total_entries => total_entries)
  end
end

But, Jan, I don't think you really need paginate_by_sql here. By what you pasted it's obvious that only a `paginate` call with :conditions is sufficient.

(from [9bd5aec3ddccfee211a2ef512148aaf8eeda9d5f]) Active Record: fix paginate_by_sql(:page => nil)

Closes #187 count SQL invalid on Oracle
https://github.com/mislav/will_paginate/commit/9bd5aec3ddccfee211a2...