helper issue when request.method != :get

on suggestion to fix this problem is to add a new pagination option: pagination_action or default_action.

in the page_link_or_span method we can easily check on request.method, if we don't get a :get request and we have a pagination_action defined, we can merge the params with the pagination_action and the page info to create a proper link.

here is an example how what I meant earlier.

I have some update and delete action called remotely which re render a div including some photos and the pagination helper.

The pagination helper is included in the div because it needs to be refreshed in case some photos were removed.

The ajax calls are using the UPDATE or DELETE methods to update or delete one or many pictures. The actions called by these remote forms have nothing to do with the action handling the pagination, however since you are merging the request params, the pagination tries to call the same action again.

I can't find a case where it would make sense for the pagination helper to make an update/delete call to any action.

Does it make more sense?

-Matt

Same problem here: If you have a nice RESTful controller that renders a list right after a new item was POSTed, the will_paginate plugin will add all the POST info all the links. The classic paginator didn't do that, I wonder how they figured out which params to include. Anyway, I solved it by modifying will_paginate so I could pass in the url options, but that's not nearly as elegant as the classic plugin did it.

Fjan, I don't think I'll be supporting that practice, but will definitely make this configurable. You will be able to mess with merged parameters as much as you want

so does that mean that the only way to generate links for the results of a post based search is to manually tell the will_paginate helper the url parameters for the generated links?

i.e will_paginate @collection, :params => {:controller => 'foo', :action => 'bar'}

Dan: yes, and you shouldn't have POST searches anyway.