Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Change page_link_or_span api to take options

#124

This is a feature request to aid with overriding this method. I was wondering if the method signature for the page_link_or_span in view_helpers could be changed to take all the options instead of just the param.

This would help me in my situation, because I want to override this method in order to generate my links in some other wacky way. At the moment I pass in a custom param, check whether its the class I'm interested in and then do my logic. With the options, I could more easily pass in all the options I need and leave the default behaviour when my options aren't present.

Thanks, Rob

Reported by Rob Dupuis · October 3rd, 2007 @ 11:47 AM

State: invalid
Milestone: none
Assigned to: Mislav Mislav

Activity

  1. Mislav
    Mislav
    • Assigned user changed from Chris Wanstrath to Mislav
    • State changed from new to open

    Definitely coming. I'll be working on this soon

    October 4th, 2007 @ 06:02 AM

  2. Rob Dupuis
    Rob Dupuis

    Things have improved with recent versions. You can now override page_or_link_span and get hold of the @options, so I'd close this ticket. Thanks.

    November 5th, 2007 @ 02:03 PM

  3. Mislav
    Mislav
    • State changed from open to invalid

    I'm closing this ticket in favor of #165, which would solve all your problems. Watch that ticket for updates from me.

    December 24th, 2007 @ 03:20 AM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.