Ignores page :params in merb

Can you try out something like this, see if it's OK?

WillPaginate::ViewHelpers::LinkRenderer.class_eval do
  protected
  
  def default_url_params
    {}
  end
  
  def url(page)
    @base_url_params ||= begin
      url_params = base_url_params
      merge_optional_params(url_params)
      url_params
    end
    
    url_params = @base_url_params.dup
    add_current_page_param(url_params, page)
    
    @template.url(:this, params)
  end
  
  def base_url_params
    url_params = default_url_params
    # page links should preserve GET parameters
    symbolized_update(url_params, @template.request.params.except(:action, :controller)) if get_request?
    url_params
  end
  
  def merge_optional_params(url_params)
    symbolized_update(url_params, @options[:params]) if @options[:params]
  end
  
  def add_current_page_param(url_params, page)
    url_params.merge('page' => page)
  end
  
  def get_request?
    @template.request.method == :get
  end
end

These are the things I actually planned to build into LinkRenderer (sans Merb-specific stuff). Currently they're only available in ActionView (which is wrong).

Thanks for reporting

I took what you sent and made a couple of little tweaks. This seems to work better for me:

WillPaginate::ViewHelpers::LinkRenderer.class_eval do
 protected

 def default_url_params
  {}
 end

 def url(page)
  @base_url_params ||= begin
    url_params = base_url_params
    merge_optional_params(url_params)
    url_params
  end

  url_params = @base_url_params.dup
  url_params = add_current_page_param(url_params, page)

  @template.url(url_params)
 end

 def base_url_params
  url_params = default_url_params
  # page links should preserve GET parameters
  symbolized_update(url_params, @template.request.params.except(:action, :controller)) if get_request?
  url_params
 end

 def merge_optional_params(url_params)
  symbolized_update(url_params, @options[:params]) if @options[:params]
 end

 def add_current_page_param(url_params, page)
  url_params.merge(:page => page)
 end

 def get_request?
  @template.request.method == :get
 end
end

Thanks for reviewing. I think we have to use string key "page" instead of symbol because otherwise the page parameter could get duplicated -- see #256 Double page params when using merb 1.0.6.1