Rails 2.2.x the binding argument of concat is no longer needed
Reported by John Small | December 31st, 2008 @ 07:31 PM
Working in mislav-will_paginate 2.3.6 and Rails 2.2.2 when calling paginated_section you'll get an error on line 145 with a deprecation warning. This;-
def paginated_section(*args, &block)
pagination = will_paginate(*args).to_s
content = pagination + capture(&block) + pagination
(line 145) concat content, block.binding
end
needs to be changed to;-
def paginated_section(*args, &block)
pagination = will_paginate(*args).to_s
content = pagination + capture(&block) + pagination
concat content
end
The extra argument to concat has been removed from Rails 2.2.x
Comments and changes to this ticket
-
John Small December 31st, 2008 @ 07:37 PM
Damm, I just saw that the change has already been committed. I did do a search on "concat" before entering the ticket. Honest!
-
Mislav January 8th, 2009 @ 03:20 PM
- Tag changed from “rails 2.2, block.binding, concat, paginate_section” to “concat, deprecation, paginate_section”
- State changed from “new” to “duplicate”
No worries :) Thanks anyway for good intentions. Closing
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Everyone's favorite Ruby library for pagination of practically anything!
John Small
Mislav