Activity (RSS)

That's a good explanation. I will look into it

I'm using rails 2.3 and have a named_scope that uses the :having option to filter results based on joined aggregate data. When using will_paginate with this, th...

Not fixed yet. Looking into it

Not sure if this has been fixed in git, but bug still exists in the current gem version (2.3.7)

I'm using the oracleenhanced adaptor, which falls into this unle...

i use the solution in this post :

http://groups.google.com/group/w...

count results are wrong when a "group by" clause appear in the query.

sorry for the incon...

will_paginate : mislav-will_paginate-2.3.6

rails : 2.2.2

and my request :

conditions = "inner join mod_icom_prods as mip on (mifo.mod_icom_prod_id = mip.id)"

co...

I don't think there is a bug - both find and count use the built-in ActiveRecord methods.

You haven't given me enough information. First tell me the will_pagina...

hi,

this is my log :

SQL (3.1ms) SELECT count(*) AS count_all, mifo.mod_icom_option_id,mip.id AS mifo_mod_icom_option_id_mip_id FROM mod_icom_files_options as m...

You may be right.

But still, little can be done from will_paginate. Maybe you guys should open a Rails ticket? On the other hand, the internal implementation of...

I*m sorry. But I think this is absolutly wrong, and will return wrong results.

When you group something by a specific value, and then count without the group op...

Dimitri and Adam - those are awesome solutions, thank you. I was in the same situation.

Mislav, this would be an awesome thing to build into WillPaginate.

Thanks. It works fine.

Ouch. Then how about

WillPaginate::LinkRenderer.class_eval do
  protected

  def url_for(page)
    url_params = {}
    # page links should preserve GET ...

The monkeypatch brokes all page links. I get "/blogs/@Andrex" instead of "/blogs/@Andres/pages/(\d+)" for any page.

On the other hand, lets rather leave this ticket open.

That is because of the internal "optimization" when generating URLs.

You can either use will_paginate 3.0 (not yet released, find it in the "agnostic" branch) o...

Given: * Rails 2.1.2 * will_paginate 2.3.6

config/routes.rb:

ActionController::Routing::Routes.draw do |map|
  RE_USER_LOGIN = /[^\/]+/

  map.with_option...

Thanks, I'll look into this

oops, here's the right diff.

has_many :uniq_replies, :source => :replies, :through => :topics, :uniq => true

pagination generates invalid sql.

from test/console

>> Project.first.uniq_...

Well, it can't hurt http://github.com/mislav/will_pa...

:P

That just says you need an ORDER BY clause, whereas in fact you need more than that - you need an ORDER BY clause that uniquely identifies and orders each recor...

I think what is there in the docs now is quite fine:

Without the ORDER BY clause, databases aren‘t required to do consistent ordering when performing SELECT qu...

My argument would be that it isn't the user who has chosen to flip the data back and forth. It is the way will_paginate processes the data that makes this an is...

What you said there --

This works fine if the field you are sorting on is unique for each record, but falls down if you have a lot of records with the same fie...

I think I have found a bug this time :o) . However, it may be a MS SQL only error as I haven't tested the problem with MySQL.

I have a table of "support cases" ...

Thanks for reviewing. I think we have to use string key "page" instead of symbol because otherwise the page parameter could get duplicated -- see #256

I took what you sent and made a couple of little tweaks. This seems to work better for me:

WillPaginate::ViewHelpers::LinkRenderer.class_eval do
 protected
...

Can you try out something like this, see if it's OK?

WillPaginate::ViewHelpers::LinkRenderer.class_eval do
  protected
  
  def default_url_params
    {}...

Using the agnostic branch. Trying to pass in explicit url params, which seem to be ignored when using will_paginate under merb.

I think doing something like

...

Glad you solved your problem :) Closing