Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Activity (RSS)

Thursday, January 08 2009
258 Rails 2.2.x the binding argument of concat is no longer needed was updated
  • Mislav
    • Tag changed from rails 2.2, block.binding, concat, paginate_section to concat, deprecation, paginate_section
    • State changed from new to duplicate
    by Mislav at 3:20 PM

    No worries :) Thanks anyway for good intentions. Closing

Wednesday, December 31 2008
258 Rails 2.2.x the binding argument of concat is no longer needed was updated
  • John Small
    John Small commented at 7:37 PM

    Damm, I just saw that the change has already been committed. I did do a search on "concat" before entering the ticket. Honest!

  • John Small
    John Small created the ticket at 7:31 PM

    Working in mislav-will_paginate 2.3.6 and Rails 2.2.2 when calling paginated_section you'll get an error on line 145 with a deprecation warning. This;-

    def pag...
Wednesday, December 24 2008
257 order by not working with joined tables was updated
  • ReggieB
    ReggieB commented at 12:23 PM

    Working on the problem further, its the square brackets causing the problem. They are commonly used in MS SQL code, but ActiveRecord seems to behave differently...

  • ReggieB
    ReggieB commented at 11:46 AM

    I've investigated this further and it is not a will_paginate bug. It's an active record bug. The same thing happens with a find :

    
    class Opportunity
      def se...
Monday, December 22 2008
257 order by not working with joined tables was updated
  • ReggieB
    ReggieB commented at 2:33 PM

    I've also tried using paginate_by_sql:

    
          sql = <<EOF
    SELECT [o].*,
      [c].[Comp_Name] AS company_name,
      [p].[Pers_Salutation] AS person_salutation,
     ...
  • ReggieB
    ReggieB commented at 2:29 PM

    Sorry - didn't get the format syntax right.

    My problem is that:

    
    ORDER BY c.comp_name
    

    becomes

    
    ORDER BY c\.comp_name
    

    My code is

    
          @opportunities ...
  • ReggieB
    ReggieB created the ticket at 2:24 PM

    I'm currently using Rails 2.1 and was using will_paginate 2.2.2. I've upgraded to mislav-will_paginate 2.3.6, but the problem persists. MS SQL 2005 database.

    Th...

Sunday, December 21 2008
256 Double page params when using merb 1.0.6.1 was updated
  • Mislav
    • State changed from new to resolved
    by Mislav at 8:06 PM

    (from [f2031833b42eaaa10a92b551846e3d4e94fb486a]) use string key for 'page' parameter when constructing URLs in Merb [phatmann] [#256 state:resolved] http://gi...

  • phatmann
    phatmann commented at 7:30 PM

    This is for the latest version of the agnostic branch.

  • phatmann
    phatmann created the ticket at 7:30 PM

    In merb 1.0.6.1, the page links are not being formed correctly after browsing to page 2, 3, etc. The links end up with double page params:

    /foo?page=2&page=5

    Th...

use string key for 'page' parameter w... was committed by Mislav Marohnić at 8:06 PM
wrap a test that uses Mocha in #uses_... was committed by Mislav Marohnić at 8:03 PM
change concat calls in #paginated_sec... was committed by Mislav Marohnić at 8:03 PM
Wednesday, December 17 2008
220 has many :through causes "Stack level too deep error" was updated
Friday, December 12 2008
255 paginate very slow on large queries with :group was updated
  • Mislav
    • State changed from open to resolved
    by Mislav at 2:23 AM

    No prob ;)

  • Michael Ragalie
    Michael Ragalie commented at 12:57 AM

    That worked like a charm. All I did was use

    
    Model.paginate :page => 1, :per_page => 10, :group => 'foo.id', :count => {:group => nil, :select => "DISTINCT fo...
Thursday, December 11 2008
255 paginate very slow on large queries with :group was updated
  • Mislav
    • State changed from new to open
    by Mislav at 11:45 PM

    That's rather unfortunate.

    Does this help?

    
    Model.paginate :page => 1, :per_page => 10,
      :group => 'foo', :count => { :group => nil }
    

    That will cause the ...

Wednesday, December 10 2008
254 Chaining named scopes with paginate doesn't work with MS SQL Server was updated
  • Jon Canady
    Jon Canady commented at 4:15 PM

    Heh. Strictly speaking the boss is wary of production table /column names leaking out, and it looks like my attempt to sanitize our data didn't work so well. So...

  • Mislav
    Mislav commented at 12:26 PM

    In the latest application I'm developing, we're really putting named scopes to the max and so far I haven't seen a single MySQL query generated incorrectly.

    So,...

255 paginate very slow on large queries with :group was created
  • Michael Ragalie
    Michael Ragalie created the ticket at 3:37 AM

    In finder.rb, wp_count() passes off to count() in order to figure out how many total results exist. When :group is specified, count() uses execute_grouped_calcu...

Tuesday, December 09 2008
247 will_paginate helper doesn't work with has_and_belongs_to_many associations. was updated
  • Mislav
    • State changed from open to invalid
    by Mislav at 4:00 PM

    This is because of a bug in ActiveRecord with Ruby 1.8.7.

    I've investigated and it looks like ruby 1.8.7 + ActiveRecord 2.1.1 = FAIL

    It's been fixed in Rails co...

  • Ivan
    Ivan commented at 4:46 AM

    Hey, I'm having the same problem, with the following model:

    class Playlist < ActiveRecord::Base has_and_belongs_to_many :songs end

    When I call @songs = Playlist...

Monday, December 08 2008
254 Chaining named scopes with paginate doesn't work with MS SQL Server was created
  • Jon Canady
    Jon Canady created the ticket at 9:11 PM

    Using activerecord-sqlserver-adapter (1.0.0) and Rails 2.2.2. Set up some nice named scopes to do things like filter by user_id and status, and then chained the...

Tuesday, November 25 2008
253 visible_page_numbers is O(n) where n is the number of pages was updated
  • Mislav
    • State changed from new to resolved
    by Mislav at 12:42 AM

    Good point. Thanks

Monday, November 24 2008
253 visible_page_numbers is O(n) where n is the number of pages was created
  • Lida Tang
    Lida Tang created the ticket at 11:01 PM

    visible_page_numbers will take a very long time if the number of pages you have is large, say if you are returning web search results that have millions of page...

Tuesday, November 11 2008
120 Association with finder_sql raises TypeError was updated
  • Adam Tretkowski
    • Tag set to will_paginate
    by Adam Tretkowski at 11:14 AM

    In my model only some relationships use finder_sql so I modified a bit your solution to make possible to chose which finder should be used and to make it access...

Friday, November 07 2008
252 git merge braid/track hit Fatal: Not a git repository was updated
  • Mislav
    • Title changed from Fwd: git merge braid/track hit Fatal: Not a git repository to git merge braid/track hit Fatal: Not a git repository
    • State changed from new to invalid
    by Mislav at 12:39 PM

    There is mention of SVN in your error messages. That's pretty weird, because will_paginate is entirely hosted in a git repository.

    This is not a will_paginate b...

  • up1notch
    up1notch created the ticket at 5:05 AM

    Encounter the following issue during installation of will_paginate:

    When trying to run the command:

    git merge braid/track
    
    

    in the dos prompt, it throw the fol...

Thursday, October 30 2008
251 Do you still need activesupport as a gem dependency? It breaks stuff... was updated
  • Mislav
    Mislav commented at 12:24 PM

    Oh, I missed that you said "activate your gems" instead of "require". All is well ;)

  • Chad Woolley
    Chad Woolley commented at 10:26 AM

    Thanks for the prompt response.

    Not sure about the "enable" comment, though.

    We only activate the gems in preinitializer, which means calling the rubygems 'gem'...

  • Mislav
    • State changed from new to resolved
    by Mislav at 10:12 AM

    Your last point is valid. The gem dependency only caused problems. Although you shouldn't load will_paginate before Rails! Then you need an extra WillPaginate::...

  • Chad Woolley
    Chad Woolley created the ticket at 1:58 AM

    I see this ticket:

    http://sod.lighthouseapp.com/pro...

    And this commit:

    http://github.com/mislav/will_pa...

    I'm wondering if we can remove it safely now, beca...

250 NoMethodError on first page (Multiple associations) was updated
  • Mislav
    • State changed from new to invalid
    by Mislav at 10:07 AM
Monday, October 27 2008
250 NoMethodError on first page (Multiple associations) was updated
  • akshay (at mugasha)
    akshay (at mugasha) commented at 10:48 AM

    You are totally right. I just checked the table and one track had a dj_set NULL. This is my fault and I apologize for blaming the plugin. Thanks for pointing th...

Sunday, October 26 2008
250 NoMethodError on first page (Multiple associations) was updated
  • Mislav
    Mislav commented at 10:20 PM

    How are you sure the plugin is causing this? From what I see from your code and error, the problem isn't in pagination at all, but in the fact that one of the T...

Saturday, October 25 2008
250 NoMethodError on first page (Multiple associations) was created
  • akshay (at mugasha)
    akshay (at mugasha) created the ticket at 4:12 AM

    Hello, I have been trying to debug this issue and then i realized that plugin was causing this.

    I am using the example of search from railscasts but I have a de...

Monday, October 20 2008
249 Add option to hide prev/next links when they point to same page was created
Monday, October 13 2008
170 Pagination links in list mode was updated
  • Mislav
    • Title changed from [idea] list mode to Pagination links in list mode
    • State changed from open to resolved
    • Tag changed from will_paginate to html, will_paginate
    by Mislav at 2:47 AM

    I've given this a lot of thought and resolved not to support list mode in core. I just don't see the semantic advantage, particularly when considering an unorde...

Wednesday, October 08 2008
Home was edited by Mislav in will_paginate library at 11:06 PM (+1 more edit)
will_paginate v3.0 ("agnostic") was created by Mislav at 11:01 PM
&nbsp;
5 of 6 tickets remain in this milestone
Tuesday, October 07 2008
Home was created by Mislav in will_paginate library at 9:09 PM